Move blocking execute operation to executor thread#2458
Closed
Arooba-git wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for reporting this @Arooba-git I think the problem is in GraphQL-Java implementation, it shouldn't load values from a resource bundles every time a graphql document is parsed. Instead, it should be cached. |
Member
|
I would suggest to report a bug to GraphQL-Java project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Thank you for this project!
This PR fixes a blocking call in execute method of graphQL handler, as detected by BlockHound:
We re-ran the tests and also compared the performance (in terms of latency) before and after the fix. The highest execution time of the event loop marginally reduces after the fix:
Before
Before
