Added query parameters getter inside RoutingContext #581
Conversation
| * | ||
| * @return the map of query parameters (if a query parameter value is an array, it will be provided as comma separated string, so if you need to extract array from query use {@link #queryParam(String)} queryParam) | ||
| */ | ||
| Map<String, String> queryParams(); |
There was a problem hiding this comment.
In order to make it correct this should be a MultiMap http://vertx.io/docs/apidocs/io/vertx/core/MultiMap.html
There was a problem hiding this comment.
Working on it, I will commit as soon as possible
| return getQueryParamsParsed().get(query); | ||
| } | ||
|
|
||
| protected void setQueryParams(Map<String, List<String>> q) { |
| queryParams.put(e.getKey(), String.join(",", e.getValue())); | ||
| } | ||
|
|
||
| private Map<String, String> getQueryParams() { |
|
|
||
| private Map<String, String> getQueryParams() { | ||
| if (queryParams == null) { | ||
| queryParams = new HashMap<>(); |
There was a problem hiding this comment.
the initial state could be fetched from the HttpServerRequest.getParams() since it does the initial parsing for us
There was a problem hiding this comment.
The real trouble is that HttpServerRequest.params() don't return only query params, It returns an unique multimap with path params and query params. I've done a small test:
Router router = Router.router(vertx);
router.route().handler(BodyHandler.create());
router.route("/:id").handler(routingContext -> {
System.out.println(Arrays.toString(routingContext.request().params().entries().toArray()));
routingContext.response().end("Hello!");
});
vertx.createHttpServer().requestHandler(router::accept).listen(8080);
Doing a request with this URL:
http://localhost:8080/ciao?ei=ao
It prints in console this: [ei: ao, id: ciao]
| return queryParams; | ||
| } | ||
|
|
||
| private Map<String, List<String>> getQueryParamsParsed() { |
There was a problem hiding this comment.
This becomes not needed if we populate from the base object and parse on setPathParams right?
|
Fixed a bug that duplicates entries in queryParams when more than one handler is set for a path |
To allow users to avoid conflicts between path parameters and query parameters, I created a query parameters getter.
Unfortunately i can't return from
queryParams()aMap<String, List<String>>because of this: https://github.com/vert-x3/vertx-codegen/blob/master/src/main/java/io/vertx/codegen/ClassModel.java#L424So:
queryParams()returns aMap<String, String>.If one query parameter is an array It will return as a comma separated listqueryParam(name)returns aList<String>, containing the query parameter value/valuesI also wrote a small unit test to test this getter