Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting when prop index is None #1200

Merged
merged 4 commits into from Apr 10, 2019
Merged

Fix deleting when prop index is None #1200

merged 4 commits into from Apr 10, 2019

Conversation

jnwatson
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 10, 2019 •
edited

Codecov Report

Merging #1200 into master will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
- Coverage   93.48%   93.46%   -0.03%     
==========================================
  Files         124      124              
  Lines       16511    16515       +4     
==========================================
  Hits        15435    15435              
- Misses       1076     1080       +4
Impacted Files Coverage Δ
synapse/lib/lmdblayer.py 89.41% <55.55%> (-0.2%) ⬇️
synapse/lib/link.py 89.28% <0%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4dbf1f...8c82d65. Read the comment docs.

vEpiphyte
vEpiphyte previously approved these changes Apr 10, 2019
View reviewed changes
@vEpiphyte vEpiphyte added this to the v0.1.2 milestone Apr 10, 2019
@vEpiphyte vEpiphyte added the bug label Apr 10, 2019
vEpiphyte
vEpiphyte reviewed Apr 10, 2019
View reviewed changes
synapse/lib/lmdblayer.py
@@ -276,17 +277,19 @@ def migrateProvPre010(self, newslab):
proputf8 = lkey[32:]
valu, indx = s_msgpack.un(lval)

# <prop><00><indx>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we not have migration / regression tests for this function???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@jnwatson jnwatson merged commit 5cf3b56 into master Apr 10, 2019
@jnwatson jnwatson deleted the delbug branch April 10, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vEpiphyte vEpiphyte vEpiphyte approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnwatson @vEpiphyte