Make cortex, view, and layer idens to be unique #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this will change the iden of the view and the default layer.
invisig0th
requested changes
Oct 18, 2019
vEpiphyte
reviewed
Oct 18, 2019
vEpiphyte
reviewed
Oct 18, 2019
vEpiphyte
reviewed
Oct 18, 2019
vEpiphyte
reviewed
Oct 18, 2019
vEpiphyte
requested changes
Oct 18, 2019
* Remove cortex _moveDict, * Add tests for hive rename and exists
* Remove a duplicate slab offset class * Add an additional delete method to slab offset class * Add unit tests for slab offset
This is for future expansion where the write layer might change.
…into uniq-iden
invisig0th
previously approved these changes
Oct 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
- Coverage 95.18% 95.11% -0.07%
==========================================
Files 133 133
Lines 19598 19649 +51
==========================================
+ Hits 18654 18690 +36
- Misses 944 959 +15
Continue to review full report at Codecov.
|
invisig0th
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this will change the iden of the view and the default layer.