Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug cryotank anit #1426

Merged
merged 3 commits into from Nov 8, 2019
Merged

Bug cryotank anit #1426

merged 3 commits into from Nov 8, 2019

Conversation

vEpiphyte
Copy link
Contributor

  • Fix cryocell anit to inherit the correct signature from Cell.
  • Remove unused path variable.
  • Fix getCellApi to use Class defined ctors instead of hardcoded ctors.

@vEpiphyte vEpiphyte added the bug label Nov 8, 2019
@vEpiphyte vEpiphyte added this to the v0.1.37 milestone Nov 8, 2019
@vEpiphyte vEpiphyte self-assigned this Nov 8, 2019
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #1426 into master will decrease coverage by 3.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
- Coverage   95.28%   91.88%   -3.41%     
==========================================
  Files         133      133              
  Lines       20053    20053              
==========================================
- Hits        19108    18426     -682     
- Misses        945     1627     +682
Flag Coverage Δ
#linux 91.88% <100%> (-0.02%) ⬇️
#osx ?
Impacted Files Coverage Δ
synapse/cryotank.py 86.62% <100%> (-1.17%) ⬇️
synapse/lib/platforms/darwin.py 0% <0%> (-100%) ⬇️
synapse/cortex.py 75.69% <0%> (-19.18%) ⬇️
synapse/lib/ast.py 78.71% <0%> (-16.04%) ⬇️
synapse/lib/thisplat.py 58.33% <0%> (-8.34%) ⬇️
synapse/lib/storm.py 89.14% <0%> (-5.74%) ⬇️
synapse/tests/utils.py 87.57% <0%> (-4.62%) ⬇️
synapse/lib/view.py 90.04% <0%> (-4.53%) ⬇️
synapse/lib/node.py 94.53% <0%> (-4.11%) ⬇️
synapse/lib/stormtypes.py 95.95% <0%> (-1.4%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c32308...1179630. Read the comment docs.

@vEpiphyte vEpiphyte merged commit 1cf69e8 into master Nov 8, 2019
@vEpiphyte vEpiphyte deleted the bug_cryotank_anit branch November 8, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant