Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leap day agenda bug #1550

Merged
merged 1 commit into from Mar 1, 2020
Merged

Fix leap day agenda bug #1550

merged 1 commit into from Mar 1, 2020

Conversation

jnwatson
Copy link
Contributor

@jnwatson jnwatson commented Feb 29, 2020

Handle next time of appointment when today is leap day.

Symptom was: ValueError: day is out of range for month when the appointment crossed years.

Handle next time of appointment when today is leap day
@codecov
Copy link

@codecov codecov bot commented Feb 29, 2020

Codecov Report

Merging #1550 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
- Coverage   94.40%   94.37%   -0.04%     
==========================================
  Files         133      133              
  Lines       23463    23466       +3     
==========================================
- Hits        22150    22145       -5     
- Misses       1313     1321       +8     
Flag Coverage Δ
#linux 94.37% <100.00%> (+<0.01%) ⬆️
#osx ?
Impacted Files Coverage Δ
synapse/lib/platforms/darwin.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/lib/thisplat.py 58.33% <0.00%> (-8.34%) ⬇️
synapse/lib/spawn.py 92.21% <0.00%> (-1.17%) ⬇️
synapse/lib/link.py 98.66% <0.00%> (-0.67%) ⬇️
synapse/daemon.py 88.98% <0.00%> (-0.30%) ⬇️
synapse/cortex.py 92.20% <0.00%> (-0.06%) ⬇️
synapse/lib/lmdbslab.py 98.10% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f577b...b3f4d22. Read the comment docs.

@vEpiphyte vEpiphyte merged commit 21bcfe2 into master Mar 1, 2020
3 of 4 checks passed
@vEpiphyte vEpiphyte deleted the omg-leap-year branch Mar 1, 2020
@vEpiphyte vEpiphyte added this to the v0.2.0 milestone Mar 1, 2020
@vEpiphyte vEpiphyte added the bug label Mar 1, 2020
vEpiphyte pushed a commit that referenced this issue Mar 1, 2020
Handle next time of appointment when today is leap day
@vEpiphyte vEpiphyte removed this from the v0.2.0 milestone Mar 2, 2020
@vEpiphyte vEpiphyte added this to the v0.1.53 milestone Mar 2, 2020
@vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Mar 2, 2020

This was cherry-picked directly in the 01x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants