Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up storm command genrs #2001

Merged
merged 2 commits into from Dec 14, 2020
Merged

Clean up storm command genrs #2001

merged 2 commits into from Dec 14, 2020

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Dec 14, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2001 (1ff4ff2) into master (2580a18) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2001      +/-   ##
==========================================
- Coverage   96.83%   96.67%   -0.16%     
==========================================
  Files         146      146              
  Lines       28625    28626       +1     
==========================================
- Hits        27718    27675      -43     
- Misses        907      951      +44     
Flag Coverage Δ
linux 96.67% <100.00%> (-0.16%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/ast.py 98.16% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 93.64% <0.00%> (-2.17%) ⬇️
synapse/cortex.py 95.98% <0.00%> (-0.78%) ⬇️
synapse/lib/hiveauth.py 96.24% <0.00%> (-0.76%) ⬇️
synapse/lib/view.py 95.35% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/lmdbslab.py 99.40% <0.00%> (-0.20%) ⬇️
synapse/lib/layer.py 98.09% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2580a18...1ff4ff2. Read the comment docs.

@invisig0th invisig0th merged commit b17804b into master Dec 14, 2020
3 checks passed
@@ -743,6 +743,8 @@ async def genx():
async for item in scmd.execStormCmd(runt, genr):
yield item

await genr.aclose()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this in a finally block (with the try at line 738) so we guarantee cleanup.

@vEpiphyte vEpiphyte added the bug label Dec 14, 2020
@vEpiphyte vEpiphyte added this to the v2.15.1 milestone Dec 14, 2020
@Cisphyx Cisphyx deleted the close-genrs branch December 14, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants