Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging configuration to universally accept ints / strs (SYN-2232) (SYN-2049) #2262

Merged
merged 7 commits into from Jun 29, 2021

Conversation

vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Jun 28, 2021

  • Synapse logging now accepts integer values as log levels
  • Storm log level now defaults to info level
  • storm log level now takes string inputs in addition to integers
  • Removed --storm-log-level cortex command line argument
  • Added documentation for storm query logging and cell logging

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #2262 (0b12dc2) into master (81782c5) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
- Coverage   97.07%   96.95%   -0.13%     
==========================================
  Files         159      159              
  Lines       32282    32303      +21     
==========================================
- Hits        31339    31318      -21     
- Misses        943      985      +42     
Flag Coverage Δ
linux 96.95% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/common.py 97.72% <100.00%> (+0.09%) ⬆️
synapse/cortex.py 96.17% <100.00%> (-0.70%) ⬇️
synapse/lib/cell.py 98.15% <100.00%> (ø)
synapse/lib/const.py 100.00% <100.00%> (ø)
synapse/tests/utils.py 93.88% <100.00%> (-2.08%) ⬇️
synapse/lib/hiveauth.py 96.19% <0.00%> (-0.73%) ⬇️
synapse/lib/view.py 93.91% <0.00%> (-0.71%) ⬇️
synapse/lib/trigger.py 94.11% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81782c5...0b12dc2. Read the comment docs.

@vEpiphyte vEpiphyte changed the title WIP - Update logging configuration to universally accept ints / strs Update logging configuration to universally accept ints / strs (SYN-2232) (SYN-2049) Jun 28, 2021
synapse/common.py Show resolved Hide resolved
@vEpiphyte vEpiphyte merged commit 34cb1b7 into master Jun 29, 2021
5 checks passed
@vEpiphyte vEpiphyte deleted the feat_storm_log branch June 29, 2021 13:09
@vEpiphyte vEpiphyte added this to the v2.4x.x milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants