Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macho model and defines (SYN-2768) #2503

Merged
merged 14 commits into from Jan 6, 2022
Merged

Macho model and defines (SYN-2768) #2503

merged 14 commits into from Jan 6, 2022

Conversation

rakuy0
Copy link
Contributor

@rakuy0 rakuy0 commented Dec 15, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #2503 (73c398c) into master (f28fb0a) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2503      +/-   ##
==========================================
- Coverage   97.19%   97.06%   -0.13%     
==========================================
  Files         195      196       +1     
  Lines       36834    36841       +7     
==========================================
- Hits        35802    35761      -41     
- Misses       1032     1080      +48     
Flag Coverage Δ
linux 97.06% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lookup/macho.py 100.00% <100.00%> (ø)
synapse/models/files.py 99.15% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 94.00% <0.00%> (-2.05%) ⬇️
synapse/lib/hiveauth.py 96.28% <0.00%> (-0.71%) ⬇️
synapse/cortex.py 96.25% <0.00%> (-0.65%) ⬇️
synapse/lib/view.py 94.81% <0.00%> (-0.58%) ⬇️
synapse/lib/trigger.py 94.88% <0.00%> (-0.40%) ⬇️
synapse/lib/layer.py 97.70% <0.00%> (-0.20%) ⬇️
synapse/lib/lmdbslab.py 99.52% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28fb0a...73c398c. Read the comment docs.

synapse/models/files.py Show resolved Hide resolved
synapse/models/files.py Outdated Show resolved Hide resolved
synapse/models/files.py Outdated Show resolved Hide resolved
synapse/models/files.py Outdated Show resolved Hide resolved
synapse/models/files.py Show resolved Hide resolved
synapse/models/files.py Show resolved Hide resolved
synapse/tests/test_model_files.py Show resolved Hide resolved
@invisig0th
Copy link
Contributor

In thinking this over, i think we should make the loadcmd fields into an interface that is implemented by the more specific ones,

@invisig0th invisig0th merged commit 961308e into master Jan 6, 2022
@invisig0th invisig0th deleted the macho_model branch January 6, 2022 21:37
@vEpiphyte vEpiphyte added this to the v2.7x.x milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants