Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add mirror option to aha:// URLs, randomize telepath client connect order, handle lists in openurl" #2682

Merged
merged 1 commit into from
May 13, 2022

Conversation

vEpiphyte
Copy link
Contributor

Reverts #2679

…onnect order, handle lists in openurl (#2679)"

This reverts commit 3dabb5d.
@vEpiphyte
Copy link
Contributor Author

Reverting this since it will be subsumed by a different PR.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #2682 (1151d4e) into master (86999ec) will decrease coverage by 0.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
- Coverage   97.01%   96.43%   -0.59%     
==========================================
  Files         206      206              
  Lines       39630    39589      -41     
==========================================
- Hits        38446    38176     -270     
- Misses       1184     1413     +229     
Flag Coverage Δ
linux 96.43% <100.00%> (-0.47%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/exc.py 99.40% <ø> (-0.01%) ⬇️
synapse/lib/aha.py 97.10% <100.00%> (-0.77%) ⬇️
synapse/lib/link.py 98.94% <100.00%> (-0.03%) ⬇️
synapse/telepath.py 94.56% <100.00%> (-0.11%) ⬇️
...napse/vendor/cashaddress/tests/test_cashaddress.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/vendor/cashaddress/base58.py 22.03% <0.00%> (-66.11%) ⬇️
synapse/vendor/cashaddress/convert.py 51.06% <0.00%> (-38.30%) ⬇️
synapse/vendor/cashaddress/crypto.py 76.47% <0.00%> (-17.65%) ⬇️
synapse/lib/node.py 92.44% <0.00%> (-5.63%) ⬇️
synapse/common.py 93.82% <0.00%> (-4.33%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86999ec...1151d4e. Read the comment docs.

@vEpiphyte vEpiphyte merged commit a418b13 into master May 13, 2022
@vEpiphyte vEpiphyte deleted the revert-2679-visi-aha-mirror branch May 13, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant