Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch transformer errors in other query modes (SYN-4133) #2840

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Sep 12, 2022

No description provided.

@vEpiphyte vEpiphyte added the bug label Sep 12, 2022
@vEpiphyte vEpiphyte added this to the v2.10x.x milestone Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 97.10% // Head: 97.00% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (e234475) compared to base (b68276d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
- Coverage   97.10%   97.00%   -0.10%     
==========================================
  Files         214      214              
  Lines       41554    41539      -15     
==========================================
- Hits        40350    40295      -55     
- Misses       1204     1244      +40     
Flag Coverage Δ
linux 97.00% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 98.66% <100.00%> (+1.06%) ⬆️
synapse/tests/utils.py 94.51% <0.00%> (-1.91%) ⬇️
synapse/cortex.py 96.68% <0.00%> (-0.58%) ⬇️
synapse/lib/hiveauth.py 95.71% <0.00%> (-0.52%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 96.98% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
synapse/lib/base.py 95.73% <0.00%> (-0.07%) ⬇️
synapse/lib/storm.py 94.92% <0.00%> (-0.05%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cisphyx Cisphyx merged commit 127831e into master Sep 12, 2022
@Cisphyx Cisphyx deleted the catch-transformer-errs branch September 12, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants