Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex minimum version #2841

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Update regex minimum version #2841

merged 2 commits into from
Sep 12, 2022

Conversation

vEpiphyte
Copy link
Contributor

Addresses segfault reported here mrabarnett/mrab-regex#479

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 97.11% // Head: 97.01% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (8920b3c) compared to base (127831e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2841      +/-   ##
==========================================
- Coverage   97.11%   97.01%   -0.11%     
==========================================
  Files         214      214              
  Lines       41554    41539      -15     
==========================================
- Hits        40354    40297      -57     
- Misses       1200     1242      +42     
Flag Coverage Δ
linux 97.01% <ø> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/tests/utils.py 94.51% <0.00%> (-1.91%) ⬇️
synapse/cortex.py 96.71% <0.00%> (-0.55%) ⬇️
synapse/lib/hiveauth.py 95.71% <0.00%> (-0.52%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 96.98% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
synapse/lib/base.py 95.73% <0.00%> (-0.07%) ⬇️
synapse/lib/layer.py 96.99% <0.00%> (-0.05%) ⬇️
synapse/lib/chop.py 98.00% <0.00%> (-0.04%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mikemoritz
mikemoritz previously approved these changes Sep 12, 2022
@vEpiphyte vEpiphyte added this to the v2.10x.x milestone Sep 12, 2022
@vEpiphyte vEpiphyte merged commit 616d3bf into master Sep 12, 2022
@vEpiphyte vEpiphyte deleted the feat_regex_update branch September 12, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants