Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aha user provisioning, telepath user resolution (SYN-4054, SYN-3953) #2850

Merged
merged 10 commits into from
Sep 26, 2022

Conversation

vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Sep 19, 2022

invert user lookup for the cell to prefer aha:network prefixed usernames over the given username.
only add aha users during provisioning if the user (by name) does not exist and does not have perms to register connections.
add aha test helpers for provisioning services.
fix call error in Base.waiter()
Drop aha support for aha provisioning across multiple aha networks.
fix typos in tools

@vEpiphyte vEpiphyte added this to the v2.10x.x milestone Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 97.12% // Head: 97.02% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (85c339c) compared to base (fb8417b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
- Coverage   97.12%   97.02%   -0.11%     
==========================================
  Files         214      214              
  Lines       41562    41594      +32     
==========================================
- Hits        40367    40356      -11     
- Misses       1195     1238      +43     
Flag Coverage Δ
linux 97.02% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/tools/aha/enroll.py 94.23% <ø> (ø)
synapse/lib/aha.py 97.99% <100.00%> (+0.02%) ⬆️
synapse/lib/base.py 94.42% <100.00%> (+0.23%) ⬆️
synapse/lib/cell.py 97.75% <100.00%> (-0.01%) ⬇️
synapse/tests/utils.py 94.41% <100.00%> (-1.65%) ⬇️
synapse/cortex.py 96.71% <0.00%> (-0.55%) ⬇️
synapse/lib/hiveauth.py 95.71% <0.00%> (-0.52%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 96.98% <0.00%> (-0.34%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

synapse/lib/aha.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte changed the title Aha root user (SYN-4054) Aha root user (SYN-4054, SYN-3953) Sep 22, 2022
invisig0th
invisig0th previously approved these changes Sep 26, 2022
@vEpiphyte vEpiphyte merged commit 8f861bc into master Sep 26, 2022
@vEpiphyte vEpiphyte changed the title Aha root user (SYN-4054, SYN-3953) Aha user provisioning, telepath user resolution (SYN-4054, SYN-3953) Sep 26, 2022
@vEpiphyte vEpiphyte modified the milestones: v2.10x.x, v2.109.0 Sep 26, 2022
@vEpiphyte vEpiphyte deleted the feat_aha_root_user branch September 28, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants