Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: New event feed and websocket endpoint. Resolves OP-1891 #2851

Merged
merged 29 commits into from
Oct 5, 2022

Conversation

rakuy0
Copy link
Contributor

@rakuy0 rakuy0 commented Sep 19, 2022

Should leave enough foundation to add more events in the future as well.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 97.15% // Head: 97.05% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (ff57a08) compared to base (c77c9d3).
Patch coverage: 97.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
- Coverage   97.15%   97.05%   -0.10%     
==========================================
  Files         214      214              
  Lines       41624    41737     +113     
==========================================
+ Hits        40439    40508      +69     
- Misses       1185     1229      +44     
Flag Coverage Δ
linux 97.05% <97.54%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/httpapi.py 96.22% <90.00%> (-0.28%) ⬇️
synapse/lib/hiveauth.py 95.95% <98.14%> (-0.28%) ⬇️
synapse/cortex.py 96.71% <100.00%> (-0.55%) ⬇️
synapse/lib/cell.py 97.84% <100.00%> (+0.09%) ⬆️
synapse/lib/layer.py 96.99% <100.00%> (-0.04%) ⬇️
synapse/lib/view.py 97.00% <100.00%> (-0.32%) ⬇️
synapse/tests/utils.py 94.41% <0.00%> (-1.83%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

synapse/cortex.py Outdated Show resolved Hide resolved
Copy link
Contributor

@invisig0th invisig0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the name of this subsystem and the clean implementation. Couple clarifications. :D

synapse/lib/cell.py Outdated Show resolved Hide resolved
synapse/lib/httpapi.py Show resolved Hide resolved
synapse/cortex.py Outdated Show resolved Hide resolved
invisig0th
invisig0th previously approved these changes Sep 26, 2022
@vEpiphyte vEpiphyte modified the milestones: v2.10x.x, v2.109.0 Sep 26, 2022
@vEpiphyte vEpiphyte modified the milestones: v2.109.0, v2.10x.x Sep 26, 2022
@vEpiphyte
Copy link
Contributor

Rakuyo is still updating this, holding for next release.

synapse/lib/cell.py Outdated Show resolved Hide resolved
synapse/lib/cell.py Outdated Show resolved Hide resolved
invisig0th
invisig0th previously approved these changes Sep 30, 2022
@rakuy0 rakuy0 merged commit 684d815 into master Oct 5, 2022
@rakuy0 rakuy0 deleted the beholder_1891 branch October 5, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants