Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backtick format strings to Storm (SYN-3786) #2870

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Oct 5, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 97.15% // Head: 97.05% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (bc2adb8) compared to base (684d815).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2870      +/-   ##
==========================================
- Coverage   97.15%   97.05%   -0.10%     
==========================================
  Files         214      214              
  Lines       41752    41748       -4     
==========================================
- Hits        40565    40520      -45     
- Misses       1187     1228      +41     
Flag Coverage Δ
linux 97.05% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm_format.py 100.00% <ø> (ø)
synapse/lib/ast.py 98.78% <100.00%> (+<0.01%) ⬆️
synapse/lib/parser.py 98.67% <100.00%> (+0.01%) ⬆️
synapse/tests/utils.py 94.41% <0.00%> (-1.83%) ⬇️
synapse/cortex.py 96.74% <0.00%> (-0.54%) ⬇️
synapse/lib/hiveauth.py 95.95% <0.00%> (-0.49%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.00% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th merged commit e0b4e6c into master Oct 6, 2022
@invisig0th invisig0th deleted the backtick-strings branch October 6, 2022 08:32
@vEpiphyte vEpiphyte added this to the v2.10x.x milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants