Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove telepath consul support, hashicorp devops notes, broken changelog link. (SYN-4185) #2873

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

vEpiphyte
Copy link
Contributor

Telepath consul support was marked as provisional in the v0.1.54 release and does not work well with aha:// based resolution.

…corp devops notes, broken changelog link. (SYN-4185)
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 97.15% // Head: 97.04% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (87cf697) compared to base (e5ed7d3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2873      +/-   ##
==========================================
- Coverage   97.15%   97.04%   -0.11%     
==========================================
  Files         214      214              
  Lines       41763    41712      -51     
==========================================
- Hits        40576    40481      -95     
- Misses       1187     1231      +44     
Flag Coverage Δ
linux 97.04% <ø> (-0.02%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/telepath.py 93.66% <ø> (-0.43%) ⬇️
synapse/tests/utils.py 94.41% <0.00%> (-1.83%) ⬇️
synapse/cortex.py 96.74% <0.00%> (-0.54%) ⬇️
synapse/lib/hiveauth.py 95.95% <0.00%> (-0.49%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.00% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
synapse/lib/lmdbslab.py 99.52% <0.00%> (-0.20%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.10x.x milestone Oct 6, 2022
@invisig0th invisig0th merged commit 61aaa53 into master Oct 6, 2022
@invisig0th invisig0th deleted the depr_telepath_consul branch October 6, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants