Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - mirror prov.done is incorrect (SYN-4275, SYN-4246) #2882

Merged
merged 6 commits into from
Oct 12, 2022

Conversation

vEpiphyte
Copy link
Contributor

Ensure we always write the prov.done file to the iden which we used to do provisioning when we boot from a mirror.

@vEpiphyte vEpiphyte added the bug label Oct 12, 2022
@vEpiphyte vEpiphyte added this to the v2.11x.x milestone Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 97.18% // Head: 97.08% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (9b45006) compared to base (f25ca69).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9b45006 differs from pull request most recent head c61bc37. Consider uploading reports for the commit c61bc37 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2882      +/-   ##
==========================================
- Coverage   97.18%   97.08%   -0.11%     
==========================================
  Files         215      215              
  Lines       41958    41947      -11     
==========================================
- Hits        40776    40723      -53     
- Misses       1182     1224      +42     
Flag Coverage Δ
linux 97.08% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/cell.py 98.13% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 94.41% <100.00%> (-1.83%) ⬇️
synapse/cortex.py 96.71% <0.00%> (-0.54%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.00% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit a36269a into master Oct 12, 2022
@vEpiphyte vEpiphyte deleted the bug_cell_prov_mirror branch October 12, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants