Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay test updates (SYN-4225) #2890

Merged
merged 16 commits into from
Oct 18, 2022
Merged

Replay test updates (SYN-4225) #2890

merged 16 commits into from
Oct 18, 2022

Conversation

vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Oct 18, 2022

  • Add withNexusReplay calls to our SynTest helpers that construct cells which did not previously have that in their call stacks.
  • Make SynTest.addSvcToAha more robust when used with the nexus double apply patch.
  • Fix bug with JsonStor q:puts message being double applied.
  • Replace most direct cell construction in unit tests with test helpers, to ensure more coverage is available for withNexusReplay.
  • Make master and tag build replay tests run the entire test suite as opposed to a subset of tests. Move nightly replay tests to weekly tests.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 97.18% // Head: 97.19% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (db1dbb6) compared to base (f7d1535).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2890   +/-   ##
=======================================
  Coverage   97.18%   97.19%           
=======================================
  Files         215      215           
  Lines       42000    42026   +26     
=======================================
+ Hits        40818    40847   +29     
+ Misses       1182     1179    -3     
Flag Coverage Δ
linux 97.08% <100.00%> (+<0.01%) ⬆️
linux_replay 96.27% <100.00%> (+21.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/jsonstor.py 98.56% <100.00%> (+0.01%) ⬆️
synapse/tests/utils.py 96.34% <100.00%> (+0.20%) ⬆️
synapse/cortex.py 97.28% <0.00%> (+0.03%) ⬆️
synapse/lib/provenance.py 99.15% <0.00%> (+0.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ouble apply on master and tag builds. Move replay nightlies to be weeklies.
@vEpiphyte vEpiphyte changed the title Feat test utils replay Replay test updates (SYN-4225) Oct 18, 2022
@vEpiphyte vEpiphyte added this to the v2.11x.x milestone Oct 18, 2022
@vEpiphyte vEpiphyte merged commit 9b80cc1 into master Oct 18, 2022
@vEpiphyte vEpiphyte deleted the feat_test_utils_replay branch October 18, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants