Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model updates 2022-10-25 #2900

Merged
merged 9 commits into from
Oct 27, 2022
Merged

Model updates 2022-10-25 #2900

merged 9 commits into from
Oct 27, 2022

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 97.14% // Head: 97.09% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (dccb742) compared to base (ebb7be8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2900      +/-   ##
==========================================
- Coverage   97.14%   97.09%   -0.06%     
==========================================
  Files         215      215              
  Lines       42041    42028      -13     
==========================================
- Hits        40840    40805      -35     
- Misses       1201     1223      +22     
Flag Coverage Δ
linux 97.09% <100.00%> (+1.13%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/models/base.py 100.00% <ø> (ø)
synapse/models/inet.py 99.52% <ø> (ø)
synapse/models/infotech.py 98.67% <ø> (ø)
synapse/models/media.py 100.00% <ø> (ø)
synapse/models/orgs.py 100.00% <ø> (ø)
synapse/models/risk.py 100.00% <ø> (ø)
synapse/lib/modelrev.py 97.83% <100.00%> (+0.01%) ⬆️
synapse/tests/utils.py 94.46% <0.00%> (-1.77%) ⬇️
synapse/cortex.py 96.71% <0.00%> (-0.58%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@therealsilence therealsilence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo

synapse/models/media.py Outdated Show resolved Hide resolved
synapse/models/risk.py Outdated Show resolved Hide resolved
mbvertex
mbvertex previously approved these changes Oct 26, 2022
@Cisphyx Cisphyx merged commit b02c363 into master Oct 27, 2022
@Cisphyx Cisphyx deleted the visi-model-20221025 branch October 27, 2022 13:31
@vEpiphyte vEpiphyte added this to the v2.11x.x milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants