Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs deprecation warnings (SYN-4257) #2905

Merged
merged 17 commits into from
Nov 14, 2022
Merged

Docs deprecation warnings (SYN-4257) #2905

merged 17 commits into from
Nov 14, 2022

Conversation

vEpiphyte
Copy link
Contributor

  • Fix use warnings.warn in synapse.common
  • Add docs for enabling deprecation warnings.
  • Fix use of List.length() in service.del implementation.
  • Update agenda to create and use a view directly instead of calling core.eval.
  • Generally remove Core.eval / CoreApi.eval from unit tests.
  • Update function docstrings for deprecated functions to note their status.

synapse/lib/storm.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 97.17% // Head: 97.17% // No change to project coverage 👍

Coverage data is based on head (7fbf8a9) compared to base (7fbf8a9).
Patch has no changes to coverable lines.

❗ Current head 7fbf8a9 differs from pull request most recent head de81266. Consider uploading reports for the commit de81266 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2905   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files         215      215           
  Lines       42084    42084           
=======================================
  Hits        40897    40897           
  Misses       1187     1187           
Flag Coverage Δ
linux 97.07% <0.00%> (ø)
linux_replay 96.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit eef34db into master Nov 14, 2022
@vEpiphyte vEpiphyte deleted the docs_warnings branch November 14, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants