OAuth V2 manager (SYN-4177)

[mikemoritz]

No description provided.

[codecov]

Codecov Report

Base: 97.17% // Head: 97.08% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (2939061) compared to base (1840467).
Patch coverage: 98.88% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
- Coverage   97.17%   97.08%   -0.10%     
==========================================
  Files         215      216       +1     
  Lines       42186    42439     +253     
==========================================
+ Hits        40996    41202     +206     
- Misses       1190     1237      +47     

Flag	Coverage Δ
linux	97.08% <98.88%> (+0.01%)	⬆️
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
synapse/lib/oauth.py	98.68% <98.68%> (ø)
synapse/cortex.py	96.50% <100.00%> (-0.57%)	⬇️
synapse/lib/stormlib/oauth.py	100.00% <100.00%> (ø)
synapse/tests/utils.py	94.46% <0.00%> (-1.89%)	⬇️
synapse/lib/hiveauth.py	96.01% <0.00%> (-0.48%)	⬇️
synapse/lib/trigger.py	95.01% <0.00%> (-0.39%)	⬇️
synapse/lib/view.py	97.00% <0.00%> (-0.34%)	⬇️
synapse/cmds/cron.py	97.56% <0.00%> (-0.25%)	⬇️
synapse/lib/jsonstor.py	98.32% <0.00%> (-0.24%)	⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[vEpiphyte]

Can't we do an identify check here since the item in the heap is a tuple who either is or is not the item we made a few lines previously and did not mutate?