Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling when Axon is streaming files (SYN-4391) #2911

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Nov 10, 2022

No description provided.

@Cisphyx Cisphyx changed the title Adjust error handling when Axon is streaming files (SYN-4391) Fix error handling when Axon is streaming files (SYN-4391) Nov 10, 2022
@vEpiphyte vEpiphyte added the bug label Nov 10, 2022
@vEpiphyte vEpiphyte added this to the v2.11x.x milestone Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 97.17% // Head: 97.07% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (2eca74c) compared to base (800f480).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2911      +/-   ##
==========================================
- Coverage   97.17%   97.07%   -0.11%     
==========================================
  Files         215      215              
  Lines       42080    42065      -15     
==========================================
- Hits        40893    40834      -59     
- Misses       1187     1231      +44     
Flag Coverage Δ
linux 97.07% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/axon.py 98.73% <100.00%> (-0.15%) ⬇️
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/cortex.py 96.65% <0.00%> (-0.57%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.00% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/lib/layer.py 96.99% <0.00%> (-0.05%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cisphyx Cisphyx merged commit 0b15440 into master Nov 10, 2022
@Cisphyx Cisphyx deleted the csvrows-fix branch November 10, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants