Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trycast the trigger.async value before displaying it (SYN-4380) #2915

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the bug label Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 97.17% // Head: 97.07% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (423bf8e) compared to base (9815ffd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2915      +/-   ##
==========================================
- Coverage   97.17%   97.07%   -0.11%     
==========================================
  Files         215      215              
  Lines       42084    42069      -15     
==========================================
- Hits        40897    40838      -59     
- Misses       1187     1231      +44     
Flag Coverage Δ
linux 97.07% <ø> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.41% <ø> (-0.01%) ⬇️
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/cortex.py 96.65% <0.00%> (-0.57%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.00% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
synapse/lib/layer.py 96.99% <0.00%> (-0.05%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.11x.x milestone Nov 14, 2022
@vEpiphyte vEpiphyte merged commit 7fbf8a9 into master Nov 14, 2022
@vEpiphyte vEpiphyte deleted the bug_trigger_list branch November 14, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants