Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unlink in AHA enroll (SYN-4399) #2926

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Fix unlink in AHA enroll (SYN-4399) #2926

merged 5 commits into from
Nov 29, 2022

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Nov 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 97.16% // Head: 97.07% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (d082dbc) compared to base (137c100).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
- Coverage   97.16%   97.07%   -0.10%     
==========================================
  Files         215      215              
  Lines       42111    42096      -15     
==========================================
- Hits        40919    40863      -56     
- Misses       1192     1233      +41     
Flag Coverage Δ
linux 97.07% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/tools/aha/enroll.py 100.00% <100.00%> (+5.76%) ⬆️
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/cortex.py 96.50% <0.00%> (-0.57%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.00% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
synapse/lib/layer.py 96.99% <0.00%> (-0.05%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.11x.x milestone Nov 28, 2022
@vEpiphyte vEpiphyte added the bug label Nov 28, 2022
@Cisphyx Cisphyx merged commit bb622f9 into master Nov 29, 2022
@Cisphyx Cisphyx deleted the aha-enrollfix branch November 29, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants