-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biz model additions #2931
Biz model additions #2931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor nits picked...
Codecov ReportBase: 97.20% // Head: 97.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2931 +/- ##
==========================================
- Coverage 97.20% 97.09% -0.11%
==========================================
Files 217 217
Lines 42773 42758 -15
==========================================
- Hits 41578 41518 -60
- Misses 1195 1240 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eb5c2e0
}), | ||
)), | ||
('biz:listing', {}, ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a :loc property be useful here to track where the product/service is being offered (where relevant)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would require another round of discussions. Feel free to submit a ticket.
}), | ||
)), | ||
('biz:listing', {}, ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a :url prop to track where the listed was being sold online?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, would require further discussions. Submit a ticket if you think it's valuable.
}), | ||
)), | ||
('biz:listing', {}, ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a :desc prop to capture product/service descriptions provided by the seller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good idea for a ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe roll them up into one ticket for additional suggested fields. Model PR reviews are mostly for show stoppers / necessary clarifications rather than suggesting new fields. 👍
No description provided.