-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
synapse.tools.storm: add support for specifying a view #2937
synapse.tools.storm: add support for specifying a view #2937
Conversation
That one test case is still failing, tried a form that will actually create 1 node instead of 2 and still no dice. I can remove it if desired, but that feels like the wrong option here :) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2937 +/- ##
==========================================
- Coverage 97.19% 97.09% -0.11%
==========================================
Files 221 221
Lines 43659 43662 +3
==========================================
- Hits 42436 42394 -42
- Misses 1223 1268 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR adds support for an optional
--view
flag for thesynapse.tools.storm
CLI tool, similar to how it works in csvtool.One of the tests I wrote doesn't work though (here), and I can't figure out for the life of me why. I tested the feature manually and it all works as expected, so I think there's some edge case in the test case I can't figure out that's causing it to fail.
closes #2860