Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapse.tools.storm: add support for specifying a view #2937

Merged
merged 13 commits into from
Mar 1, 2023

Conversation

captainGeech42
Copy link
Contributor

@captainGeech42 captainGeech42 commented Dec 3, 2022

This PR adds support for an optional --view flag for the synapse.tools.storm CLI tool, similar to how it works in csvtool.

One of the tests I wrote doesn't work though (here), and I can't figure out for the life of me why. I tested the feature manually and it all works as expected, so I think there's some edge case in the test case I can't figure out that's causing it to fail.

closes #2860

synapse/lib/cli.py Outdated Show resolved Hide resolved
synapse/tools/storm.py Outdated Show resolved Hide resolved
@captainGeech42
Copy link
Contributor Author

That one test case is still failing, tried a form that will actually create 1 node instead of 2 and still no dice. I can remove it if desired, but that feels like the wrong option here :)

synapse/tools/storm.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (2644fdf) 97.19% compared to head (9c19506) 97.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2937      +/-   ##
==========================================
- Coverage   97.19%   97.09%   -0.11%     
==========================================
  Files         221      221              
  Lines       43659    43662       +3     
==========================================
- Hits        42436    42394      -42     
- Misses       1223     1268      +45     
Flag Coverage Δ
linux 97.09% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/tools/storm.py 97.29% <100.00%> (+0.03%) ⬆️
synapse/tests/utils.py 94.49% <0.00%> (-1.88%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.02% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.47% <0.00%> (-0.14%) ⬇️
synapse/lib/layer.py 96.60% <0.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@captainGeech42
Copy link
Contributor Author

nice

@invisig0th invisig0th merged commit 4a46e02 into vertexproject:master Mar 1, 2023
@captainGeech42 captainGeech42 deleted the zander/issues/2860 branch March 2, 2023 00:20
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Mar 2, 2023
@vEpiphyte vEpiphyte added reqChangelog requires changelog and removed reqChangelog requires changelog labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] storm & cmdr - add view and optsfile arguments
4 participants