Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snap.addnode warning messages. #2951

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Fix snap.addnode warning messages. #2951

merged 2 commits into from
Dec 20, 2022

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the bug label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 97.17% // Head: 95.48% // Decreases project coverage by -1.69% ⚠️

Coverage data is based on head (5bf6174) compared to base (906ae21).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
- Coverage   97.17%   95.48%   -1.70%     
==========================================
  Files         215      215              
  Lines       42175    42160      -15     
==========================================
- Hits        40985    40255     -730     
- Misses       1190     1905     +715     
Flag Coverage Δ
linux 95.48% <100.00%> (-1.59%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/snap.py 94.87% <100.00%> (ø)
synapse/tools/moduser.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/tools/json2mpk.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/cmds/trigger.py 14.77% <0.00%> (-84.66%) ⬇️
synapse/lib/stormlib/backup.py 43.47% <0.00%> (-56.53%) ⬇️
synapse/cmds/cortex.py 50.51% <0.00%> (-48.10%) ⬇️
synapse/lib/stormhttp.py 65.24% <0.00%> (-34.76%) ⬇️
synapse/lib/modelrev.py 71.66% <0.00%> (-26.12%) ⬇️
synapse/lib/stormlib/yaml.py 75.00% <0.00%> (-25.00%) ⬇️
synapse/lib/msgpack.py 74.64% <0.00%> (-23.95%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit f31e47b into master Dec 20, 2022
@vEpiphyte vEpiphyte deleted the bug_snap_addnode branch December 20, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants