Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow pkg.add to mutate packages (SYN-4546) #2963

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

vEpiphyte
Copy link
Contributor

Remove the $pkg.url and $pkg.loaded values from being set by the pkg.add Storm command since this may mutate a signed package (SYN-4546)

@vEpiphyte vEpiphyte added this to the v2.11x.x milestone Jan 2, 2023
@vEpiphyte vEpiphyte changed the title Do not allow pkg.add to mutate packagse (SYN-4546) Do not allow pkg.add to mutate packages (SYN-4546) Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 97.20% // Head: 97.09% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (2761097) compared to base (5888da1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2963      +/-   ##
==========================================
- Coverage   97.20%   97.09%   -0.11%     
==========================================
  Files         217      217              
  Lines       42767    42752      -15     
==========================================
- Hits        41571    41511      -60     
- Misses       1196     1241      +45     
Flag Coverage Δ
linux 97.09% <ø> (+0.54%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.42% <ø> (-0.01%) ⬇️
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/cortex.py 96.50% <0.00%> (-0.57%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.00% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added the bug label Jan 2, 2023
@vEpiphyte vEpiphyte merged commit fd7e8e7 into master Jan 3, 2023
@vEpiphyte vEpiphyte deleted the bug_pkgadd_metadata branch January 3, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants