Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement extended permissions for macros (SYN-4544, SYN-942, SYN-4440, OP-1126) #2973

Merged
merged 34 commits into from
Jan 13, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 97.19% // Head: 97.09% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (ef3239b) compared to base (6eb0b49).
Patch coverage: 98.17% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
- Coverage   97.19%   97.09%   -0.11%     
==========================================
  Files         217      217              
  Lines       42820    42988     +168     
==========================================
+ Hits        41621    41740     +119     
- Misses       1199     1248      +49     
Flag Coverage Δ
linux 97.09% <98.17%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 96.55% <96.74%> (-0.56%) ⬇️
synapse/lib/cell.py 98.26% <100.00%> (+0.04%) ⬆️
synapse/lib/hive.py 92.32% <100.00%> (+0.03%) ⬆️
synapse/lib/stormlib/macro.py 100.00% <100.00%> (ø)
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cisphyx Cisphyx changed the title WIP: implement extended permissions for macros Implement extended permissions for macros (SYN-4544, SYN-942, SYN-4440, OP-1126) Jan 11, 2023
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Jan 12, 2023
@Cisphyx Cisphyx merged commit d351dde into master Jan 13, 2023
@Cisphyx Cisphyx deleted the visi-macroperms branch January 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants