inet model bugfixes (SYN-4552, SYN-4561) #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.20% // Head: 97.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2982 +/- ##
==========================================
- Coverage 97.20% 97.09% -0.12%
==========================================
Files 217 217
Lines 43003 42992 -11
==========================================
- Hits 41801 41742 -59
- Misses 1202 1250 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Cisphyx
previously approved these changes
Jan 13, 2023
invisig0th
requested changes
Jan 13, 2023
synapse/models/inet.py
Outdated
| @@ -198,7 +198,11 @@ def _normPyStr(self, valu): | |||
|
|
|||
| try: | |||
| user, fqdn = valu.split('@', 1) | |||
| except ValueError: | |||
| mesg = f'Cannot split the email user and fqdn for "{valu}"' | |||
There was a problem hiding this comment.
Maybe something about the missing @ sign? Something like Email address expected in <user>@<fqdn> format: {valu} or something?
Cisphyx
approved these changes
Jan 13, 2023
invisig0th
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inet:dns:soaproperties are now writable.inet:emailnorm now catches a python ValueError during splitting and raises a BadTypeValu directly when that happens.