-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify disk space before starting backups (SYN-4578) #2990
Conversation
Codecov ReportBase: 97.21% // Head: 97.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
- Coverage 97.21% 97.11% -0.11%
==========================================
Files 218 218
Lines 43198 43188 -10
==========================================
- Hits 41996 41940 -56
- Misses 1202 1248 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
synapse/lib/cell.py
Outdated
diskfree = shutil.disk_usage(self.backdirn).free | ||
cellsize, _ = s_common.getDirSize(self.dirn) | ||
if cellsize * 2 > diskfree: | ||
mesg = f'Insufficient free space on {self.backdirn} to run a backup' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to tell them how much disk space we currently detect available; in use and what our backup requirements are. That could make this message actionable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated message to include free and required space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actionable exception
No description provided.