Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro creator when creating macros (SYN-4668) #2993

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Conversation

vEpiphyte
Copy link
Contributor

  • Add a missing user argument to the _initStormMacro in Cortex.addStormMacro
  • Add test for non-admin user creating / deleting their own macro

@vEpiphyte vEpiphyte added the bug label Jan 23, 2023
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 97.21% // Head: 97.11% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (3bc48e1) compared to base (b33a018).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2993      +/-   ##
==========================================
- Coverage   97.21%   97.11%   -0.11%     
==========================================
  Files         218      218              
  Lines       43203    43188      -15     
==========================================
- Hits        42001    41940      -61     
- Misses       1202     1248      +46     
Flag Coverage Δ
linux 97.11% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 96.68% <100.00%> (-0.55%) ⬇️
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/cmds/cron.py 97.56% <0.00%> (-0.25%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th merged commit c6d1215 into master Jan 23, 2023
@invisig0th invisig0th deleted the bug_macro_owner branch January 23, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants