Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove provenance APIs and provstor cache (SYN-4465) #2995

Merged
merged 5 commits into from
Jan 26, 2023

Conversation

vEpiphyte
Copy link
Contributor

  • Remove provenance APIs and provstor cache. Does not remove any existing slabs on disk.
  • Does not remote the runtime recursion protections

@vEpiphyte vEpiphyte added this to the v2.122.0 milestone Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 97.21% // Head: 97.06% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (3bc7fce) compared to base (75dd8b5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
- Coverage   97.21%   97.06%   -0.16%     
==========================================
  Files         218      218              
  Lines       43204    43120      -84     
==========================================
- Hits        42002    41853     -149     
- Misses       1202     1267      +65     
Flag Coverage Δ
linux 97.06% <100.00%> (-0.06%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cmds/cortex.py 97.92% <ø> (-0.70%) ⬇️
synapse/cortex.py 96.72% <ø> (-0.51%) ⬇️
synapse/lib/provenance.py 87.30% <ø> (-11.86%) ⬇️
synapse/lib/snap.py 94.84% <ø> (-0.04%) ⬇️
synapse/tests/utils.py 94.46% <ø> (-1.89%) ⬇️
synapse/lib/rstorm.py 99.42% <100.00%> (ø)
synapse/lib/slabseqn.py 96.17% <0.00%> (-2.19%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Cisphyx Cisphyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the ProvStack stuff for anything besides tracking recursion? Seems like we could clean it up a bit if that's all we're using it for but I suppose that can be a different story.

@vEpiphyte
Copy link
Contributor Author

@Cisphyx Current story was scoped to removing the ongoing storage and APIs, not redoing the recursion protections.

@vEpiphyte vEpiphyte merged commit f45b683 into master Jan 26, 2023
@vEpiphyte vEpiphyte deleted the deprecate_provenance_apis branch January 26, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants