Skip to content

Remove unnecessary perm check when moving sodes (SYN-4664) #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Jan 27, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 97.16% // Head: 97.06% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (0d93326) compared to base (92fc8df).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
- Coverage   97.16%   97.06%   -0.11%     
==========================================
  Files         218      218              
  Lines       43140    43142       +2     
==========================================
- Hits        41918    41875      -43     
- Misses       1222     1267      +45     
Flag Coverage Δ
linux 97.06% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.48% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
synapse/lib/layer.py 96.59% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th merged commit 23c6588 into master Feb 1, 2023
@invisig0th invisig0th deleted the sode-permchecks branch February 1, 2023 15:11
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants