Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the HTTPAPI onepass logic to the Cell (SYN-4396) #3004

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 97.18% // Head: 97.08% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (70adcbb) compared to base (dc5428e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
- Coverage   97.18%   97.08%   -0.10%     
==========================================
  Files         218      218              
  Lines       43145    43152       +7     
==========================================
- Hits        41929    41893      -36     
- Misses       1216     1259      +43     
Flag Coverage Δ
linux 97.08% <100.00%> (+0.04%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/cell.py 98.33% <100.00%> (+0.01%) ⬆️
synapse/lib/httpapi.py 97.35% <100.00%> (-0.03%) ⬇️
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit 5b6b589 into master Feb 3, 2023
@vEpiphyte vEpiphyte deleted the feat_cell_onepass branch February 3, 2023 13:42
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 3, 2023
@vEpiphyte vEpiphyte changed the title Move the HTTPAPI onepass logic to the Cell (SYN-4234) Move the HTTPAPI onepass logic to the Cell (SYN-4396) Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants