Skip to content

Clean up read-only props in datamodel (SYN-4663) #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Feb 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 97.18% // Head: 97.08% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (7a35362) compared to base (3539624).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3005      +/-   ##
==========================================
- Coverage   97.18%   97.08%   -0.11%     
==========================================
  Files         218      218              
  Lines       43171    43171              
==========================================
- Hits        41957    41912      -45     
- Misses       1214     1259      +45     
Flag Coverage Δ
linux 97.08% <ø> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/models/dns.py 100.00% <ø> (ø)
synapse/tests/utils.py 94.46% <0.00%> (-1.89%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.73% <0.00%> (-0.15%) ⬇️
synapse/lib/layer.py 96.59% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 8, 2023
@Cisphyx Cisphyx merged commit dbedb82 into master Feb 8, 2023
@Cisphyx Cisphyx deleted the ro-cleanup branch February 8, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants