Cell.Ahainfo updates (SYN-4490, SYN-5194)

[vEpiphyte]

• Remove the Cell.ahaclient Telepath client from being cached in the synapse.lib.aha_clients dictionary. This allows the Cell Aha client to operate independently of a (potentially) globally cached client. This simplifies unit testing with multiple cells communicating with a single Aha service, as the client is now properly fini'd upon teardown of the cell. Since the AhaApi class maintains state for the service registration, this also means a user interacting with the global object directly cannot not affect the state of the service registration for a Cell.

• Change the cell.ahaino from being a static constant to being generated on demand by Cell.getAhaInfo(). This allows the cell to report the correct ready status to the Aha service, instead of a potentailly invalid static value. The previous behavior presented as having a incorrect ready status upon the Aha service restarting & service mirrors reporting the incorrect status.

• When the cell mirror loop exits, it now reports its ready status to the Aha service. This allows a service to mark itself as "not ready" since exiting that loop may mean it is no longer in the realtime change window.

• Fix a bug in nexus._tellAhaReady(self, status) which passed in a static value ( True ) to the Aha service instead of the the status value being passed in.

[codecov]

Codecov Report

Patch coverage: 97.05% and project coverage change: -0.11 ⚠️

Comparison is base (6c549f4) 97.27% compared to head (ea73288) 97.17%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
- Coverage   97.27%   97.17%   -0.11%     
==========================================
  Files         222      222              
  Lines       44035    44049      +14     
==========================================
- Hits        42835    42804      -31     
- Misses       1200     1245      +45     

Flag	Coverage Δ
linux	97.17% <97.05%> (+<0.01%)	⬆️
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
synapse/lib/cell.py	98.42% <96.42%> (-0.05%)	⬇️
synapse/lib/nexus.py	97.12% <100.00%> (+0.04%)	⬆️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.