Skip to content

Axon and Storm wget improvements (SYN-4675) #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 15, 2023
Merged

Axon and Storm wget improvements (SYN-4675) #3011

merged 13 commits into from
Feb 15, 2023

Conversation

vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Feb 9, 2023

  • Axon.wget() now includes the request and redirect history information
  • $lib.axon.wget now includes the original URL in its response
  • Storm wget / $lib.axon.urlfile now makes inet:urlfile nodes based on the original request URL to preserve pivoting 1:1 from a URL to the urlfile node.
  • Storm wget / $lib.axon.urlfile now makes inet:urlredir nodes based on the redirect history information. The first node in the chain uses the original request url to preserve pivoting 1:1 from the url to the redirection chain.

- Axon.wget() now includes the request and redirect history information
- $lib.axon.wget now includes the original URL in its response
- $lib.axon.urlfile now makes inet:urlfile nodes based on the original request URL to preserve pivoting 1:1 from a URL to the urlfile node.
- $lib.axon.urlfile now makes inet:urlredir nodes based on the redirect history information
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 97.20% // Head: 97.09% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (e21163f) compared to base (2a99ce8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3011      +/-   ##
==========================================
- Coverage   97.20%   97.09%   -0.11%     
==========================================
  Files         220      220              
  Lines       43370    43395      +25     
==========================================
- Hits        42156    42136      -20     
- Misses       1214     1259      +45     
Flag Coverage Δ
linux 97.09% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/axon.py 98.74% <100.00%> (-0.14%) ⬇️
synapse/lib/stormtypes.py 98.61% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 94.49% <100.00%> (-1.86%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

- Axon.wget() now includes the request and redirect history information
- $lib.axon.wget now includes the original URL in its response
- Storm wget / $lib.axon.urlfile now makes inet:urlfile nodes based on the original request URL to preserve pivoting 1:1 from a URL to the urlfile node.
- Storm wget / $lib.axon.urlfile now makes inet:urlredir nodes based on the redirect history information. The first node in the chain uses the original request url to preserve pivoting 1:1 from the url to the redirection chain.
@vEpiphyte vEpiphyte changed the title WIP - Axon and Storm wget improvements (SYN-4675) Axon and Storm wget improvements (SYN-4675) Feb 10, 2023
@vEpiphyte vEpiphyte requested review from whippit, Cisphyx and invisig0th and removed request for whippit February 10, 2023 15:34
@vEpiphyte vEpiphyte requested a review from Cisphyx February 10, 2023 20:08
@vEpiphyte vEpiphyte requested a review from Cisphyx February 15, 2023 14:37
Cisphyx
Cisphyx previously approved these changes Feb 15, 2023
@vEpiphyte vEpiphyte merged commit f9b28d3 into master Feb 15, 2023
@vEpiphyte vEpiphyte deleted the bug_wget_pivot branch February 15, 2023 19:23
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants