Skip to content

Bug: Storm tree command did not use tostr() (SYN-4898) #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the bug label Feb 9, 2023
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 9, 2023
Cisphyx
Cisphyx previously approved these changes Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 97.18% // Head: 96.49% // Decreases project coverage by -0.70% ⚠️

Coverage data is based on head (27aef68) compared to base (dbedb82).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3012      +/-   ##
==========================================
- Coverage   97.18%   96.49%   -0.70%     
==========================================
  Files         218      218              
  Lines       43171    43171              
==========================================
- Hits        41957    41657     -300     
- Misses       1214     1514     +300     
Flag Coverage Δ
linux 96.49% <100.00%> (-0.60%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.47% <100.00%> (-0.05%) ⬇️
synapse/tools/pushfile.py 0.00% <0.00%> (-100.00%) ⬇️
...napse/vendor/cashaddress/tests/test_cashaddress.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/vendor/cashaddress/base58.py 22.03% <0.00%> (-66.11%) ⬇️
synapse/lib/hashset.py 50.00% <0.00%> (-50.00%) ⬇️
synapse/models/dns.py 59.32% <0.00%> (-40.68%) ⬇️
synapse/vendor/cashaddress/convert.py 51.06% <0.00%> (-38.30%) ⬇️
synapse/lib/stormlib/mime.py 64.70% <0.00%> (-35.30%) ⬇️
synapse/lib/gis.py 80.55% <0.00%> (-19.45%) ⬇️
synapse/vendor/cashaddress/crypto.py 76.47% <0.00%> (-17.65%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit 263ae11 into master Feb 9, 2023
@vEpiphyte vEpiphyte deleted the bug_storm_tree branch February 9, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants