Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a value to uniq based on (SYN-4850) #3018

Merged
merged 10 commits into from
Feb 15, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Feb 14, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 97.20% // Head: 97.09% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (c8f489f) compared to base (5ccfddb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3018      +/-   ##
==========================================
- Coverage   97.20%   97.09%   -0.11%     
==========================================
  Files         220      220              
  Lines       43400    43411      +11     
==========================================
- Hits        42187    42150      -37     
- Misses       1213     1261      +48     
Flag Coverage Δ
linux 97.09% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.53% <100.00%> (+0.02%) ⬆️
synapse/tests/utils.py 94.49% <0.00%> (-1.88%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.59%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/lib/lmdbslab.py 99.53% <0.00%> (-0.19%) ⬇️
synapse/axon.py 98.74% <0.00%> (-0.14%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog

@Cisphyx
Copy link
Contributor Author

Cisphyx commented Feb 15, 2023

Add changelog

Changelog updated

@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 15, 2023
@Cisphyx Cisphyx merged commit 5d6541e into master Feb 15, 2023
@Cisphyx Cisphyx deleted the uniq-pval branch February 15, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants