Skip to content

Support choices in Storm command arguments (SYN-4673) #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

mikemoritz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 97.20% // Head: 97.10% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (27b0c31) compared to base (f3b72f4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3019      +/-   ##
==========================================
- Coverage   97.20%   97.10%   -0.11%     
==========================================
  Files         220      220              
  Lines       43411    43447      +36     
==========================================
- Hits        42197    42188       -9     
- Misses       1214     1259      +45     
Flag Coverage Δ
linux 97.10% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.60% <100.00%> (+0.06%) ⬆️
synapse/tests/utils.py 94.49% <0.00%> (-1.88%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.74% <0.00%> (-0.14%) ⬇️
synapse/lib/layer.py 96.60% <0.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mikemoritz mikemoritz merged commit 767c08f into master Feb 16, 2023
@mikemoritz mikemoritz deleted the redox-stormcmd-choices branch February 16, 2023 14:59
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants