Skip to content

Adjust Storm grammar to allow funccalls when specifying tagprops (SYN-4940) #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Feb 16, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 97.20% // Head: 97.10% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (8c22015) compared to base (767c08f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3020      +/-   ##
==========================================
- Coverage   97.20%   97.10%   -0.11%     
==========================================
  Files         220      220              
  Lines       43447    43447              
==========================================
- Hits        42233    42188      -45     
- Misses       1214     1259      +45     
Flag Coverage Δ
linux 97.10% <ø> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 98.72% <ø> (ø)
synapse/lib/storm_format.py 100.00% <ø> (ø)
synapse/tests/utils.py 94.49% <0.00%> (-1.88%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.01% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.74% <0.00%> (-0.14%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added the bug label Feb 16, 2023
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Feb 16, 2023
@Cisphyx Cisphyx merged commit 8e46d79 into master Feb 16, 2023
@Cisphyx Cisphyx deleted the tagprop-grammarfix branch February 16, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants