Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove value from exceptions where it could be non-jsonsafe (SYN-4960, SYN-4775, SYN-4957) #3029

Merged
merged 11 commits into from
Mar 8, 2023

Conversation

mikemoritz
Copy link
Contributor

  • Also fixes a mesg format issue in reqjsonsafe
  • Differentiates the two reqjsonsafe functions in common.py

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (9c767b7) 97.21% compared to head (f99efbe) 97.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3029      +/-   ##
==========================================
- Coverage   97.21%   97.11%   -0.11%     
==========================================
  Files         221      221              
  Lines       43741    43760      +19     
==========================================
- Hits        42522    42496      -26     
- Misses       1219     1264      +45     
Flag Coverage Δ
linux 97.11% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/common.py 98.11% <100.00%> (ø)
synapse/lib/ast.py 98.79% <100.00%> (+<0.01%) ⬆️
synapse/lib/node.py 98.06% <100.00%> (ø)
synapse/lib/stormhttp.py 100.00% <100.00%> (ø)
synapse/lib/stormtypes.py 98.61% <100.00%> (+<0.01%) ⬆️
synapse/lib/types.py 97.62% <100.00%> (+<0.01%) ⬆️
synapse/models/inet.py 99.25% <100.00%> (ø)
synapse/tools/genpkg.py 100.00% <100.00%> (ø)
synapse/tests/utils.py 94.49% <0.00%> (-1.88%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

synapse/lib/ast.py Outdated Show resolved Hide resolved
synapse/lib/ast.py Outdated Show resolved Hide resolved
Cisphyx
Cisphyx previously approved these changes Mar 1, 2023
@invisig0th invisig0th merged commit adc01d1 into master Mar 8, 2023
@invisig0th invisig0th deleted the exc-jsonsafe branch March 8, 2023 15:38
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants