login and authdeny consistency (SYN-4870)

[vEpiphyte]

• Ensure locked users cannot login with dmon SSL listeners
• AuthDeny errors now report the associated useriden in the user key, and the username in the username key. Previously this behavior was inconsistent.

[codecov]

Codecov Report

Patch coverage: 98.55% and project coverage change: +44.65 🎉

Comparison is base (adc01d1) 52.46% compared to head (f1d014c) 97.12%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3035       +/-   ##
===========================================
+ Coverage   52.46%   97.12%   +44.65%     
===========================================
  Files         220      221        +1     
  Lines       43741    43766       +25     
===========================================
+ Hits        22950    42507    +19557     
+ Misses      20791     1259    -19532     

Flag	Coverage Δ
linux	97.12% <98.55%> (?)
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
synapse/lib/hive.py	92.32% <0.00%> (+37.88%)	⬆️
synapse/cortex.py	96.72% <100.00%> (+47.38%)	⬆️
synapse/lib/cell.py	98.44% <100.00%> (+33.82%)	⬆️
synapse/lib/hiveauth.py	96.33% <100.00%> (+29.82%)	⬆️
synapse/lib/storm.py	95.69% <100.00%> (+62.19%)	⬆️
synapse/lib/stormlib/cell.py	99.07% <100.00%> (+74.07%)	⬆️
synapse/lib/stormlib/notifications.py	100.00% <100.00%> (+61.53%)	⬆️
synapse/lib/stormlib/oauth.py	100.00% <100.00%> (+60.81%)	⬆️
synapse/lib/stormlib/project.py	99.32% <100.00%> (+69.30%)	⬆️
synapse/lib/stormtypes.py	98.66% <100.00%> (+58.43%)	⬆️
... and 149 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.