Skip to content

Mark storm auth get/list functions safe for readonly use #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (80b03dd) 97.21% compared to head (d41c38a) 97.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
- Coverage   97.21%   97.11%   -0.11%     
==========================================
  Files         221      221              
  Lines       43729    43737       +8     
==========================================
- Hits        42510    42473      -37     
- Misses       1219     1264      +45     
Flag Coverage Δ
linux 97.11% <100.00%> (+0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormtypes.py 98.61% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 94.49% <0.00%> (-1.88%) ⬇️
synapse/cortex.py 96.72% <0.00%> (-0.56%) ⬇️
synapse/lib/hiveauth.py 96.01% <0.00%> (-0.48%) ⬇️
synapse/lib/oauth.py 98.68% <0.00%> (-0.44%) ⬇️
synapse/lib/trigger.py 95.01% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 97.02% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.32% <0.00%> (-0.24%) ⬇️
synapse/axon.py 98.47% <0.00%> (-0.14%) ⬇️
synapse/lib/layer.py 96.60% <0.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th merged commit 69c0483 into master Mar 8, 2023
@invisig0th invisig0th deleted the visi-authfuncs-readonly branch March 8, 2023 14:38
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Mar 8, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog and removed reqChangelog requires changelog labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants