Skip to content

Add port to getAhaUrls default urls (SYN-5016) #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 4, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Mar 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (23d10b6) 97.26% compared to head (cfefc4d) 97.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
- Coverage   97.26%   97.16%   -0.10%     
==========================================
  Files         222      222              
  Lines       43899    43910      +11     
==========================================
- Hits        42697    42666      -31     
- Misses       1202     1244      +42     
Flag Coverage Δ
linux 97.16% <100.00%> (+0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/aha.py 98.55% <100.00%> (+0.54%) ⬆️
synapse/lib/cell.py 98.46% <100.00%> (+<0.01%) ⬆️
synapse/tools/aha/enroll.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Apr 4, 2023
vEpiphyte
vEpiphyte previously approved these changes Apr 4, 2023
vEpiphyte
vEpiphyte previously approved these changes Apr 4, 2023
@Cisphyx Cisphyx merged commit 98cd448 into master Apr 4, 2023
@Cisphyx Cisphyx deleted the update-ahaurls branch April 4, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants