Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional flag for Storm package dependencies (SYN-5012) #3058

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Mar 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (c1c0537) 97.23% compared to head (777b610) 97.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
- Coverage   97.23%   97.12%   -0.11%     
==========================================
  Files         222      222              
  Lines       43879    43882       +3     
==========================================
- Hits        42666    42622      -44     
- Misses       1213     1260      +47     
Flag Coverage Δ
linux 97.12% <100.00%> (+0.47%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.74% <ø> (ø)
synapse/cortex.py 96.72% <100.00%> (-0.55%) ⬇️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vEpiphyte
vEpiphyte previously approved these changes Mar 28, 2023
@Cisphyx Cisphyx merged commit a4802d8 into master Mar 30, 2023
@Cisphyx Cisphyx deleted the optional-deps branch March 30, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants