Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow passing non-string var names to Storm (SYN-4104) #3059

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Mar 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.28 ⚠️

Comparison is base (a4802d8) 95.81% compared to head (796cc71) 95.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3059      +/-   ##
==========================================
- Coverage   95.81%   95.54%   -0.28%     
==========================================
  Files         222      222              
  Lines       43882    43889       +7     
==========================================
- Hits        42047    41935     -112     
- Misses       1835     1954     +119     
Flag Coverage Δ
linux 95.54% <100.00%> (+6.43%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/snap.py 94.66% <100.00%> (-0.19%) ⬇️

... and 40 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added the bug label Mar 28, 2023
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Mar 28, 2023
@Cisphyx Cisphyx merged commit 9835928 into master Mar 30, 2023
@Cisphyx Cisphyx deleted the strvars-only branch March 30, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants