Skip to content

Fix for view.addNode() Storm API perms and return value #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 30, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (9835928) 97.24% compared to head (0b62e28) 97.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3060      +/-   ##
==========================================
- Coverage   97.24%   97.14%   -0.11%     
==========================================
  Files         222      222              
  Lines       43889    43897       +8     
==========================================
- Hits        42679    42642      -37     
- Misses       1210     1255      +45     
Flag Coverage Δ
linux 97.14% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormtypes.py 98.74% <100.00%> (+<0.01%) ⬆️
synapse/lib/view.py 97.03% <100.00%> (-0.32%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Cisphyx
Cisphyx previously approved these changes Mar 30, 2023
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Mar 30, 2023
@vEpiphyte vEpiphyte added the bug label Mar 30, 2023
@vEpiphyte vEpiphyte merged commit 1249289 into master Mar 30, 2023
@vEpiphyte vEpiphyte deleted the visi-view-addnode-fix branch March 30, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants