Skip to content

Add highlight context to AST/parser exceptions #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
May 5, 2023
Merged

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 98.10% and project coverage change: -0.51 ⚠️

Comparison is base (67f34c7) 97.29% compared to head (f9abc16) 96.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3063      +/-   ##
==========================================
- Coverage   97.29%   96.78%   -0.51%     
==========================================
  Files         222      222              
  Lines       44154    44164      +10     
==========================================
- Hits        42958    42743     -215     
- Misses       1196     1421     +225     
Flag Coverage Δ
linux 96.78% <98.10%> (-0.41%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cmds/trigger.py 15.95% <0.00%> (-83.49%) ⬇️
synapse/lib/ast.py 98.85% <98.69%> (+0.06%) ⬆️
synapse/lib/parser.py 98.61% <99.16%> (-0.12%) ⬇️
synapse/cmds/cron.py 97.72% <100.00%> (-0.08%) ⬇️
synapse/cortex.py 96.86% <100.00%> (-0.49%) ⬇️
synapse/datamodel.py 95.59% <100.00%> (+0.17%) ⬆️
synapse/exc.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/stix.py 99.10% <100.00%> (ø)
synapse/lib/stormtypes.py 98.75% <100.00%> (-0.01%) ⬇️
synapse/lib/types.py 95.91% <100.00%> (-1.71%) ⬇️
... and 3 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

infime
infime previously approved these changes Apr 21, 2023
@infime
Copy link
Contributor

infime commented Apr 21, 2023

looking good from the optic side 👍

Cisphyx
Cisphyx previously approved these changes May 1, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 2, 2023
@invisig0th invisig0th changed the title WIP: Add highlight context to AST/parser exceptions Add highlight context to AST/parser exceptions May 2, 2023
@vEpiphyte vEpiphyte removed this from the v2.13x.x milestone May 3, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 3, 2023
@vEpiphyte vEpiphyte added the reqChangelog requires changelog label May 3, 2023
@invisig0th invisig0th requested a review from vEpiphyte May 5, 2023 12:44
@vEpiphyte vEpiphyte merged commit 0b1ef7e into master May 5, 2023
@vEpiphyte vEpiphyte deleted the visi-highlight branch May 5, 2023 18:27
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants